Fix audio height in 100% mode #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you'll be able to look at this soon? This fixes an issue I have where the audio player appears in a container that is narrow and has audio elements set to |
|
Sorry about that. Github wouldn't let me auto-merge and I forgot to manually push it in. I'll do it as soon as I can. |
|
No problem. Wasn't sure if it was just forgotten or needed more explanation or something. I'm going to rebase it right now, and then GitHub should let it auto merge. |
This changes the way the audio player works in the 100% width mode. Since audio elements don't actually have a height, the controls are the only height to the audio element. This makes it so the audio player will still be the height of the controls if the progress is set to autosize.
|
Awesome. |
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Fix audio height in 100% mode
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Fix audio height in 100% mode
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Fix audio height in 100% mode
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Fix audio height in 100% mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way the audio player works in the 100% width mode. Since audio elements don't actually have a height, the controls are the only height to the audio element. This makes it so the audio player will still be the height of the controls if the progress is set to autosize.