Select first source that is supported by the browser #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndyer
added a commit
that referenced
this pull request
Dec 20, 2012
Select first source that is supported by the browser
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Select first source that is supported by the browser
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Select first source that is supported by the browser
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Select first source that is supported by the browser
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Select first source that is supported by the browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my point of view it makes sense to use the first compatible media file instead of the last one if provided via setSrc().
Example:
element.setSrc([
{type: 'video/mp4', src: 'video.mp4'},
{type: 'video/webm', src: 'video.webm'}])
]);
In this case Google Chrome would select the webm file although it supports mp4 files as well. This is inconsistent with the HTML5 syntax where the first supported source will be used.