Adding rounding to volume slider left, top, and and width setters #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndyer
added a commit
that referenced
this pull request
Dec 31, 2012
Adding rounding to volume slider left, top, and and width setters
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Adding rounding to volume slider left, top, and and width setters
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Adding rounding to volume slider left, top, and and width setters
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Adding rounding to volume slider left, top, and and width setters
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Adding rounding to volume slider left, top, and and width setters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers behave differently when the volume slider is positioned with floating point numbers. Rounding the values individually is the best way to ensure we have an accurate and consistent display throughout.
I tried committing this earlier but I didn't check my work and had a few syntax errors... this one will work fine.