Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element. #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixed: When the player's "remove" function is called it doesn't remove the internal reference to the removed player. When the pauseOtherPlayers option is true, the player being used is flash and the flash dom element has been removed an error is thrown when the next video is played.
johndyer
added a commit
that referenced
this pull request
Mar 11, 2013
Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
mediaelement#788 tried to fix part of what mediaelement#779 did, but didn't acknowledge that `mejs.players` is no longer an array, being an object now (a change introduced by mediaelement#779). As such, remove() now throws a "splice is not defined" error at that point. This fix replaces the line added by mediaelement#788 with mediaelement#779's equivalent, but preserves (and rectifies) the comment above.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
"splice is not a function" fix on MEP.remove() [follow-up from mediaelement#779 and mediaelement#788]
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
mediaelement#788 tried to fix part of what mediaelement#779 did, but didn't acknowledge that `mejs.players` is no longer an array, being an object now (a change introduced by mediaelement#779). As such, remove() now throws a "splice is not defined" error at that point. This fix replaces the line added by mediaelement#788 with mediaelement#779's equivalent, but preserves (and rectifies) the comment above.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
mediaelement#788 tried to fix part of what mediaelement#779 did, but didn't acknowledge that `mejs.players` is no longer an array, being an object now (a change introduced by mediaelement#779). As such, remove() now throws a "splice is not defined" error at that point. This fix replaces the line added by mediaelement#788 with mediaelement#779's equivalent, but preserves (and rectifies) the comment above.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
"splice is not a function" fix on MEP.remove() [follow-up from mediaelement#779 and mediaelement#788]
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
"splice is not a function" fix on MEP.remove() [follow-up from mediaelement#779 and mediaelement#788]
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Bug fix for the error "this.pluginApi.pauseMedia is not a function" when using the flash player and removing the dom element.
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
mediaelement#788 tried to fix part of what mediaelement#779 did, but didn't acknowledge that `mejs.players` is no longer an array, being an object now (a change introduced by mediaelement#779). As such, remove() now throws a "splice is not defined" error at that point. This fix replaces the line added by mediaelement#788 with mediaelement#779's equivalent, but preserves (and rectifies) the comment above.
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
"splice is not a function" fix on MEP.remove() [follow-up from mediaelement#779 and mediaelement#788]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the player's "remove" function is called it doesn't
remove the internal reference to the removed player. This means that when the below are true an error is thrown when the next video is played.