Option for custom error message when no plugins are found. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndyer
added a commit
that referenced
this pull request
May 25, 2013
Option for custom error message when no plugins are found.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Option for custom error message when no plugins are found.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Option for custom error message when no plugins are found.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Option for custom error message when no plugins are found.
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Option for custom error message when no plugins are found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to be able to i.e. prompt the user to install Flash if they were on a platform requiring Flash and it was not yet installed.
This is a very simple implementation, you can just provide an error message in the mejs options. If it is not provided, you get the current message, a download link to the media file.
I need the functionality, but I'm not attached to this implementation. If anybody favors a different approach, please let me know.