Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here's a fix for Safari to play video on HTTPS site #845

Merged
merged 1 commit into from
May 25, 2013
Merged

Here's a fix for Safari to play video on HTTPS site #845

merged 1 commit into from
May 25, 2013

Conversation

benroy73
Copy link
Contributor

No description provided.

@johndyer johndyer merged commit 96c2ff2 into mediaelement:master May 25, 2013
@pamelafox-coursera
Copy link

Is there a longer explanation for this change somewhere? Is Safari unable to play

@benroy73
Copy link
Contributor Author

benroy73 commented Jul 6, 2013

It's been a while since I tested so I just tested again with the current browser versions and it looks like it's only HTTPS basic authentication that's broken for Safari and Android. This should probably be updated to detect the basic authentication if that's possible.

@pamelafox-coursera
Copy link

We ended up disabling the check in our code since that issue is apparently
only if your certificate isn't set up correctly (according to stuff I found
when I google'd trying to figure out why it was put in), and our certs are
fine. Our videos are working fine (on coursera.org) without it in Safari.

On Fri, Jul 5, 2013 at 5:25 PM, benroy73 notifications@github.com wrote:

It's been a while since I tested so I just tested again with the current
browser versions and it looks like it's only HTTPS basic authentication
that's broken for Safari and Android. This should probably be updated to
detect the basic authentication if that's possible.


Reply to this email directly or view it on GitHubhttps://github.com//pull/845#issuecomment-20545517
.

@benroy73
Copy link
Contributor Author

benroy73 commented Jul 6, 2013

I'm only testing with h264 encoded videos. I think it's not really about the certs (assuming they're installed correctly and trusted by your browser), but more about whether the browser uses an imbedded media player (like chrome) or an external one like Quicktime for Safari. I suspect due to security reasons browsers don't pass on the username/password for basic auth to the external player, but they are just fine passing along access to the authentication cookies.

If someone knows a way (or I find one) to detect if the browser is using basic auth, then I'll try to integrate that with mediaelement.

@benroy73
Copy link
Contributor Author

I think pull request #937 will be a decent solution. Sites using basic auth will have to set the option but everyone else will be able to leave it to it's default off state and Safari will use it's HTML5 player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants