Fixed issue #677 #868
Merged
Fixed issue #677 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related with #677 |
|
Thanks! Could you resubmit this without changes to the /build/ folder? |
|
Sure, Tomorrow or the day after tomorrow I resubmit without change on build folder |
|
Hello, @johndyer I restore the files on build folder to the previous versión. |
|
Sorry about that. We had a branch problem in merging. Will do. On Thu, May 30, 2013 at 10:36 AM, David García notifications@github.comwrote:
John Dyer - http://j.hn/ |
|
Can I do something? |
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
With this versions of windows, IE can't reproduce html5 media elements, but all functions are aviable, so if you check video.canPlayType !== 'undefined' return true, but if you call the function video.canPlayType("video/mp4") then a exception is throwed.
I add a piece of code that after check video.canPlayType !== 'undefined', I put a try/catch, to check if function work or not, if function throw exception, I set supportsMediaTag = false.