-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding a div to search a webentity, color its links whether they are …
- Loading branch information
Showing
3 changed files
with
164 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 9a7d61b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the leftover todolist from #255 is done, we shall review together the whole logic of selectedWebentity, because currently when clicking a node, we go through the following process:
- networkNodeClick
- then the watcher on selectedWebentity activates
- then findNode is also called (twice now) from the search inputs, which calls networkNodeClick twice more
So we're recoloring the links once in color, then in grey, then twice in color
like in other places, this could be more simply $timeout($scope.onStageClick) since we're just defining a new function which only calls another function