Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBENTITY] display error message from API response when editing a WE's metadata #304

Closed
paulgirard opened this issue Apr 5, 2019 · 3 comments

Comments

@paulgirard
Copy link
Member

paulgirard commented Apr 5, 2019

In web entity, if I decide to change home page to a web page which does not match a prefix, the api replies :

[{"message": {"homepage": "WARNING: this page does not belong to this WebEntity, you should either add the corresponding prefix or merge the other WebEntity."}, "code": "fail"}]

The Interface correctly warn that there were an error but does not display the useful message.

The error message returned by Hyphe should be displayed in the notification bar as a feedback so that the user knows he should change his input.
Even better, inputting an outside-prefixes homepage could trigger a modal proposing to add the corresponding prefix or merge the corresponding entity if it exists the same way it does in the Crawls page when adding a new startpage

@paulgirard
Copy link
Member Author

Might be true elsewhere.

@boogheta
Copy link
Member

boogheta commented Apr 5, 2019

it used to do it, but @jacomyma didn't redo it in his refactoring of the edit WE menu :p

@boogheta boogheta added this to the Frontend advanced milestone May 29, 2019
@boogheta boogheta changed the title display error message from API response display error message from API response when editing a WE's metadata Sep 27, 2019
@boogheta
Copy link
Member

It should be fixed by copying the API error message within the status header bar

@boogheta boogheta changed the title display error message from API response when editing a WE's metadata [WEBENTITY] display error message from API response when editing a WE's metadata Sep 27, 2019
@boogheta boogheta closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants