New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does URI.fragmentQuery not return URI #139

Closed
ooxi opened this Issue Mar 5, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@ooxi

ooxi commented Mar 5, 2014

Hi,

would it be possible for URI.fragmentQuery to return URI instead of a {}?

That way one could require(['URI.fragmentQuery'], function(URI) {}) instead of having to require both URI and URI.fragmentQuery.

-- ooxi

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Mar 5, 2014

Member

My goal is to drop the fragment plugins and replace them with URI.fragment(true) always returning a URI instance - see #129.

I'm not sure if I can do this in 1.13.0 or have to go 2.0.0 according to semver. I would prefer the former, but this could be considered a break in API conformance.

When that change lands, both plugins would be removed and this request would be void.

Member

rodneyrehm commented Mar 5, 2014

My goal is to drop the fragment plugins and replace them with URI.fragment(true) always returning a URI instance - see #129.

I'm not sure if I can do this in 1.13.0 or have to go 2.0.0 according to semver. I would prefer the former, but this could be considered a break in API conformance.

When that change lands, both plugins would be removed and this request would be void.

@ooxi

This comment has been minimized.

Show comment
Hide comment
@ooxi

ooxi Mar 6, 2014

I'm not sure I understood what URI.fragment(true) should do? If you change the plugins to fragmentQuery / fragmentUri instead of overloading fragment I think you would have to bump the version of the hole package.

But since this major API change seems to be not in the near future, would you consider changing the return value of the fragment plugins in a minor version?

ooxi commented Mar 6, 2014

I'm not sure I understood what URI.fragment(true) should do? If you change the plugins to fragmentQuery / fragmentUri instead of overloading fragment I think you would have to bump the version of the hole package.

But since this major API change seems to be not in the near future, would you consider changing the return value of the fragment plugins in a minor version?

@rodneyrehm rodneyrehm closed this in ac93cda Mar 8, 2014

@ooxi

This comment has been minimized.

Show comment
Hide comment
@ooxi

ooxi Mar 11, 2014

Thanks!

ooxi commented Mar 11, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment