Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing query where it is no param name #243

Closed
kodentsev opened this issue Aug 21, 2015 · 6 comments
Closed

removing query where it is no param name #243

kodentsev opened this issue Aug 21, 2015 · 6 comments

Comments

@kodentsev
Copy link

@kodentsev kodentsev commented Aug 21, 2015

For example,
URI('http://hvgbook.net/?=5640').readable()===http://hvgbook.net/
URI('http://hvgbook.net/?=2500').readable()===http://hvgbook.net/

While it is 2 different pages.
Other methods (such as unicode()) lead to the same result.

@rodneyrehm
Copy link
Member

@rodneyrehm rodneyrehm commented Aug 21, 2015

according to the url specification that is considered legal, interesting.

are you up to fixing the issue and sending a pull request?

@kodentsev
Copy link
Author

@kodentsev kodentsev commented Aug 21, 2015

Yep, I've just done it

@rodneyrehm
Copy link
Member

@rodneyrehm rodneyrehm commented Sep 26, 2015

@kodentsev care to send your fix as a pull request against master?

@kodentsev
Copy link
Author

@kodentsev kodentsev commented Sep 26, 2015

OK, no problem

@rodneyrehm
Copy link
Member

@rodneyrehm rodneyrehm commented Dec 7, 2015

ping @kodentsev

@rodneyrehm
Copy link
Member

@rodneyrehm rodneyrehm commented Oct 20, 2019

fixed in 1.19.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants