Skip to content

Commit

Permalink
chore(tokenlist): cleanup after #148
Browse files Browse the repository at this point in the history
  • Loading branch information
rodneyrehm committed Aug 23, 2016
1 parent 0228a08 commit a977a19
Show file tree
Hide file tree
Showing 16 changed files with 6 additions and 17 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Expand Up @@ -9,11 +9,10 @@
* adding [`ally.element.focus`][ally/element/focus] - [issue #121](https://github.com/medialize/ally.js/issues/121)
* removing `svgelement.prototype.focus` as this should be covered more elegantly by [`ally.element.focus`][ally/element/focus]
* fixing [`ally.element.disabled`][ally/element/disabled] to remove SVG links from the document's tabbing order in Firefox
* bumping [domtokenlist-shim](https://github.com/jwilsson/domtokenlist) to not break in IE8 - [issue #112](https://github.com/medialize/ally.js/issues/112)
* [build] switching to [lint-staged](https://github.com/okonet/lint-staged) for faster linting during git pre-commit
* running all [supports][ally/supports] tests in a batch to limit number of reflows - [issue #142](https://github.com/medialize/ally.js/issues/142)
* [build] adding [rollupify](https://github.com/nolanlawson/rollupify/) to reduce package overhead in build bundle

* replacing [domtokenlist-shim](https://github.com/jwilsson/domtokenlist) by [`ally.util.toggleClass`][ally/util] - [issue #147](https://github.com/medialize/ally.js/issues/147)

## 1.1.1 - Augmented Reality

Expand Down
2 changes: 1 addition & 1 deletion GOALS.md
Expand Up @@ -16,7 +16,7 @@ With ally.js v1.0.0 I've laid the foundation for a library solving the "stupid p
* [ ] implement a DOM based interface to simplify handling [WAI-ARIA state attributes](http://www.w3.org/TR/wai-aria/states_and_properties) (along the lines of [IBM-Watson/a11y.js](https://github.com/IBM-Watson/a11y.js))
* easily creating unique-IDs for linking elements e.g. `<label for="uniq-123">…</label><input id="uniq-123">`
* toggling states
* easy support for multiple-id-values, e.g. `aria-labeledby="id-1 id-2 id-3"` possibly via [DOMTokenList](https://dom.spec.whatwg.org/#interface-domtokenlist)
* easy support for multiple-id-values, e.g. `aria-labeledby="id-1 id-2 id-3"` possibly via [DOMTokenList](https://dom.spec.whatwg.org/#interface-domtokenlist), e.g. via [tokenlist](https://github.com/rodneyrehm/tokenlist)
* [ ] implement a keyboard command abstraction that maps the keyboard interactions suggested by [WAI-ARIA Authoring Practices](http://www.w3.org/WAI/PF/aria-practices/) (e.g. [Listbox](http://www.w3.org/WAI/PF/aria-practices/#Listbox)) to [Indie UI Event Triggers](https://w3c.github.io/indie-ui/indie-ui-events.html#triggers)
* [ ] implement the corresponding [Indie UI Event Actions](https://w3c.github.io/indie-ui/indie-ui-events.html#actions) against DOM elements depending on their `role="…"` attribute

Expand Down
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -34,7 +34,6 @@ ally.js is a JavaScript library simplifying certain accessibility features, func
* [ES5-shim](https://github.com/es-shims/es5-shim) (implicitly expected)
* [ES6-shim Array.prototype.findIndex](https://github.com/paulmillr/Array.prototype.findIndex) (or complete [ES6-shim](https://github.com/paulmillr/es6-shim))
* [CSSOM CSS.escape polyfill](https://github.com/mathiasbynens/CSS.escape)
* [domtokenlist-shim](https://github.com/jwilsson/domtokenlist)


## Resources
Expand Down
1 change: 0 additions & 1 deletion docs/api/prototype.md
Expand Up @@ -15,7 +15,6 @@ Additionally ally.js uses the following third party polyfills:

* [`CSS.escape`](https://github.com/mathiasbynens/CSS.escape) to polyfill the [CSSOM `CSS.escape`](https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape) function
* [array.prototype.findindex](https://github.com/paulmillr/Array.prototype.findIndex) to polyfill the [ES6 `Array.findIndex`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex)
* [domtokenlist-shim](https://github.com/jwilsson/domtokenlist) to polyfill the [Element.classList](https://developer.mozilla.org/en/docs/Web/API/Element/classList) interface


## Contributing
Expand Down
3 changes: 3 additions & 0 deletions docs/api/util.md
Expand Up @@ -117,3 +117,6 @@ A component's `engage()` function may return an result object. The decorated `di
* `util/get-frame-element` returns the `<iframe>` or `<object>` the element is hosted in.
* `util/get-window` returns the `window` (also known as `defaultView`) of the document and element is attached to.`util/get-window` returns the `window` (also known as `defaultView`) of the document and element is attached to.

### Mutate Element.className (classList)

`util/toggle-class` mutates a given element's `class` attribute without using [`classList`](https://developer.mozilla.org/en/docs/Web/API/Element/classList), as this is not consistently available on `Element` and `SVGEelement`.
2 changes: 0 additions & 2 deletions docs/getting-started.md
Expand Up @@ -15,7 +15,6 @@ The UMD bundle contains the following dependencies:
* [platform.js](https://github.com/bestiejs/platform.js) because parsing the userAgent string yourself is ludicrous.
* [ES6-shim Array.prototype.findIndex](https://github.com/paulmillr/Array.prototype.findIndex) because loading the entire ES6-shim is unnecessary.
* [CSSOM CSS.escape polyfill](https://github.com/mathiasbynens/CSS.escape) for properly constructing CSS query selectors.
* [domtokenlist-shim](https://github.com/jwilsson/domtokenlist) for proper [`.classList`](https://developer.mozilla.org/en/docs/Web/API/Element/classList) support.


## Downloading the UMD bundle
Expand Down Expand Up @@ -149,7 +148,6 @@ require.config({
'ally.js': 'node_modules/ally.js/amd',
// provide paths to dependencies
'array.prototype.findindex': 'node_modules/array.prototype.findindex/index',
'domtokenlist-shim': 'node_modules/domtokenlist-shim',
'css.escape': 'node_modules/css.escape/css.escape',
'platform': 'node_modules/platform/platform',
},
Expand Down
2 changes: 1 addition & 1 deletion docs/legal.md
Expand Up @@ -19,7 +19,7 @@ The logo is a composition of the [United Nations Accessibility Logo](http://www.
In its UMD bundle ally.js contains resources of the following projects:

* [array.prototype.findindex](https://github.com/paulmillr/Array.prototype.findIndex), also MIT license
* [domtokenlist-shim](https://github.com/jwilsson/domtokenlist), also MIT license
* [domtokenlist-shim](https://github.com/jwilsson/domtokenlist), also MIT license, removed in `v#master`
* [css.escape](https://github.com/mathiasbynens/CSS.escape), also MIT license
* [platform.js](https://github.com/bestiejs/platform.js), also MIT License

Expand Down
1 change: 0 additions & 1 deletion test/helper/worker.js
Expand Up @@ -7,7 +7,6 @@ require.config({
'ally.js': '../../dist/amd',
// provide paths to dependencies
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
platform: '../../node_modules/platform/platform',
},
Expand Down
1 change: 0 additions & 1 deletion test/pages/element.disabled.test.html
Expand Up @@ -51,7 +51,6 @@ <h1>Element Disabled</h1>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform'
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/fix.pointer-focus-children.test.html
Expand Up @@ -111,7 +111,6 @@ <h2>Flexed Redirect</h2>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform',
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/fix.pointer-focus-input.test.html
Expand Up @@ -102,7 +102,6 @@ <h2>Non-Focusable</h2>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform',
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/fix.pointer-focus-parent.test.html
Expand Up @@ -48,7 +48,6 @@ <h2>Link</h2>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform',
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/maintain.tab-focus.test.html
Expand Up @@ -31,7 +31,6 @@ <h1>Maintain Tab Focus</h1>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform'
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/observe.interaction-type.test.html
Expand Up @@ -14,7 +14,6 @@ <h1>Observe Interaction Type</h1>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform'
}
Expand Down
1 change: 0 additions & 1 deletion test/pages/style.focus-within.test.html
Expand Up @@ -34,7 +34,6 @@ <h1>Style focus-within</h1>
ally: '../../dist/amd',
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'css.escape': '../../node_modules/css.escape/css.escape',
'platform': '../../node_modules/platform/platform'
}
Expand Down
1 change: 0 additions & 1 deletion tests/focusable/focusable.js
Expand Up @@ -5,7 +5,6 @@ require.config({
// shims required by ally.js
'array.prototype.findindex': '../../node_modules/array.prototype.findindex/index',
'css.escape': '../../node_modules/css.escape/css.escape',
'domtokenlist-shim': '../../node_modules/domtokenlist-shim',
'es6-promise': '../../node_modules/es6-promise/dist/es6-promise',
// stuff used for testing and co
platform: '../../node_modules/platform/platform',
Expand Down

0 comments on commit a977a19

Please sign in to comment.