Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors and warnings in Chrome #68

Closed
svenheden opened this issue Nov 22, 2015 · 3 comments
Closed

Errors and warnings in Chrome #68

svenheden opened this issue Nov 22, 2015 · 3 comments
Labels
improve
Milestone
1.1.0 - second wave

Comments

@svenheden
Copy link
Contributor

I get the following errors and warnings in my console (Chrome v46.0.2490.86 on OS X) when running ally.js...

screen shot 2015-11-22 at 09 40 48
@rodneyrehm
Copy link
Member

Unfortunately we won't get rid of these errors any time soon. See Supports API for an explanation. The net::ERR_INVALID_URL errors are irrelevant (caused by invalid DataURIs). The /deep/ combinator warning is deceptive, because /deep/ is remains supported in the static profile (used by querySelector() et al). See Dynamic vs Static Selector Profiles and CSS Scoping Module.

Do we need to make that clearer in the docs?

@rodneyrehm rodneyrehm mentioned this issue Nov 30, 2015
Open
@rodneyrehm
Copy link
Member

It turns out we can get rid of the net:ERR_INVALID_URL messages by providing a valid data uri that doesn't satisfy the expected media type. This way we don't have to add dummy mp3 and mp4 payload to the code base…

rodneyrehm added a commit that referenced this issue Dec 6, 2015
@rodneyrehm
refactor(supports): extracting data uris to reduce size and console e…
06c565a 
…rrors - #68
@svenheden
Copy link
Contributor Author

Sounds good! 👍

@rodneyrehm rodneyrehm mentioned this issue Dec 6, 2015
Merged
@rodneyrehm rodneyrehm added this to the 1.1.0 - second wave milestone Dec 6, 2015
@rodneyrehm rodneyrehm removed the ready label Dec 12, 2015
rodneyrehm added a commit that referenced this issue Dec 12, 2015
@rodneyrehm
docs(CHANGELOG): adding notes on #68, #60
22d452f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improve
Projects
None yet
Milestone
1.1.0 - second wave
Development

No branches or pull requests
2 participants
@svenheden @rodneyrehm