Build/adding rollupify #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyrehm
force-pushed
the
build/adding-rollupify
branch
from
829484e
to
9687d8c
Compare
rodneyrehm
force-pushed
the
build/adding-rollupify
branch
from
9687d8c
to
ece93a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces rollupify to the browserify build step. This simple change achieves a reduction of file size from 127K to 76K (28K to 23K gzipped). To verify everything still works as expected,
test/browser.bundlewas introduced to run the unit tests on the bundle, rather than the AMD files.The downside of this change is
npm run analyze:bundlehas become quite meaningless, as it now shows ally.js as one huge file, rather than many smaller packages.