Changing mmconfig form from Pashua to GTKDialog #274
Conversation
tinytomato
force-pushed
the
mmconfig
branch
from
b018018
to
8f30cd1
Compare
mmconfig
Outdated
|
|
||
| if EXIT="OK" ; | ||
| then GTK_OUTPUT="$(gtkdialog --program=MAIN_DIALOG | sort)" | ||
| echo "${GTK_OUTPUT}" | sed 's:VOLADJUSTY="true":VOLADJUST="Y":g'';''s:VOLADJUSTN="false"::g'';''s:VOLADJUSTN="true":VOLADJUST="N":g'';''s:VOLADJUSTY="false"::g'';''s:PREMIS_DBY="true":PREMIS_DB="Y":g'';''s:PREMIS_DBN="false"::g'';''s:PREMIS_DBN="true":PREMIS_DB="N":g'';''s:PREMIS_DBY="false"::g'';''s:EXIT="OK"::g'';' | sort > "${MM_CONFIG_FILE}" |
There was a problem hiding this comment.
I think this could be
echo "${GTK_OUTPUT}" | sed 's:VOLADJUSTY="true":VOLADJUST="Y":g;s:VOLADJUST[YN]="false"::g;s:VOLADJUSTN="true":VOLADJUST="N":g;s:PREMIS_DBY="true":PREMIS_DB="Y":g;s:PREMIS_DB[YN]="false"::g;s:PREMIS_DBN="true":PREMIS_DB="N":g;s:EXIT="OK"::g' | sort > "${MM_CONFIG_FILE}"
mmconfig
Outdated
| ENTRY_LABEL="${2}" | ||
| ENTRY_WIDTH="${3}" | ||
| if [[ -n "${ENTRY_VAR_VALUE}" ]] ; | ||
| then ENTRY_DEFAULT="<default>${ENTRY_VAR_VALUE}</default>" |
There was a problem hiding this comment.
I suggest line breaks and spacing like
if [[ condition ]] ; then
things
fi
mmconfig
Outdated
| LTO_INDEX_DIR.type = openbrowser | ||
| LTO_INDEX_DIR.label = Please navigate to and select the LTO_INDEX_DIR directory that you've created: | ||
| LTO_INDEX_DIR.width = 270 | ||
| idth = 270 |
There was a problem hiding this comment.
also all the stuff below seems accidentally there
|
If I run |
…t conditional based on comments
| cat << GTK_PART | ||
| <frame ${DIR_VAR_NAME}> | ||
| <hbox> | ||
| <entry accept="directory" fs-entry="Select a Directory"> |
There was a problem hiding this comment.
Can these be arranged so that they are wider? Currently they are so narrow that the full path is rarely seen, so I have to click in the box to move to the end to see what the path is.
mmconfig
Outdated
| </entry> | ||
| <button> | ||
| <input file stock="gtk-open"></input> | ||
| <variable>DIRBROWSE</variable> |
There was a problem hiding this comment.
Is this variable needed? It doesn't seem used.
mmconfig
Outdated
| $(funcDirectory LOCAL_MM_DIR) | ||
| </hbox> | ||
| </frame> | ||
| <frame> |
There was a problem hiding this comment.
can you add a name to this frame like you do with the others
mmconfig
Outdated
| </text> | ||
| <vbox> | ||
| <radiobutton> | ||
| $(funcrdoCreate VOLADJUSTY "Y") |
There was a problem hiding this comment.
having the function close a node that was opened outside of that function is ... -_-
mmconfig
Outdated
|
|
||
| GTK_OUTPUT="$(gtkdialog --program=MAIN_DIALOG | sort)" | ||
| if [[ "$GTK_OUTPUT" == *'EXIT="OK"'* ]]; then | ||
| echo "${GTK_OUTPUT}" | sed 's:VOLADJUSTY="true":VOLADJUST="Y":g;s:VOLADJUST[YN]="false"::g;s:VOLADJUSTN="true":VOLADJUST="N":g;s:PREMIS_DBY="true":PREMIS_DB="Y":g;s:PREMIS_DB[YN]="false"::g;s:PREMIS_DBN="true":PREMIS_DB="N":g;s:EXIT="OK"::g' | sort > "${MM_CONFIG_FILE}" |
There was a problem hiding this comment.
as noted maybe this sed can be cleaned up if some unneeded variables are set to not export out of gtk
No description provided.