Resolve the no-increment-decrement rule issues

mediamonks · Oct 12, 2017 · 8f31f26 · 8f31f26
1 parent 9a15290
commit 8f31f26
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/lib/EventDispatcher.ts b/src/lib/EventDispatcher.ts
@@ -89,7 +89,7 @@ export default class EventDispatcher extends sengDisposable implements IEventDis
 			event.target = this.target;
 			event.eventPhase = callTree.length === 1 ? EventPhase.AT_TARGET : EventPhase.CAPTURING_PHASE;
 
-			for (let i = 0; i < callTree.length; i++) {
+			for (let i = 0; i < callTree.length; i += 1) {
 				const currentTarget = callTree[i];
 				event.currentTarget = currentTarget;
 				if (currentTarget === this) {
@@ -172,7 +172,7 @@ export default class EventDispatcher extends sengDisposable implements IEventDis
 		} else if (!this.listeners[eventType]) {
 			return false;
 		} else {
-			for (let i = 0; i < this.listeners[eventType].length; i++) {
+			for (let i = 0; i < this.listeners[eventType].length; i += 1) {
 				const listenerData: EventListenerData = this.listeners[eventType][i];
 				if (
 					listenerData.handler === handler &&
@@ -269,7 +269,7 @@ export const removeListenersFrom = (
 			if (matchesEventType && listeners.hasOwnProperty(i) && listeners[i] instanceof Array) {
 				const listenersForType = listeners[i];
 				// traverse the array in reverse. this will make sure removal does not affect the loop
-				for (let j = listenersForType.length; j; j--) {
+				for (let j = listenersForType.length; j; j -= 1) {
 					const listenerData: EventListenerData = listenersForType[j - 1];
 					if (
 						(!handler || handler === listenerData.handler) &&
@@ -318,7 +318,7 @@ export const getCallTree = (target: EventDispatcher, bubbles: boolean): Array<Ev
 	const callTree: Array<EventDispatcher> = [];
 	const parents: Array<EventDispatcher> = getParents(target);
 
-	for (let i = parents.length; i; i--) {
+	for (let i = parents.length; i; i -= 1) {
 		callTree.push(parents[i - 1]);
 	}
 	callTree.push(target);
@@ -343,7 +343,7 @@ export const callListeners = (listeners: EventListenerMap, event: IEvent): boole
 	const listenersOfType: Array<EventListenerData> = listeners[event.type] ? [...listeners[event.type]] : [];
 	let propagationIsStopped = false;
 
-	for (let i = 0; i < listenersOfType.length; i++) {
+	for (let i = 0; i < listenersOfType.length; i += 1) {
 		const disabledOnPhase = listenersOfType[i].useCapture ? EventPhase.BUBBLING_PHASE : EventPhase.CAPTURING_PHASE;
 		if (event.eventPhase !== disabledOnPhase && !listenersOfType[i].isRemoved) {
 			const callResult: number = event.callListener(listenersOfType[i].handler);

diff --git a/tslint.json b/tslint.json
@@ -7,7 +7,6 @@
     "prefer-array-literal": [ true, { "allow-type-parameters": true } ],
     "variable-name": [ true, "allow-pascal-case" ],
     "import-name": true,
-    "no-increment-decrement": false,
     "indent": [true, "tabs"],
     "ter-indent": [
       true,