Ensure out-timelines are cleared before re-setting them up in getTime… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line When using the transitionContext to nest a child’s out-timeline in a parent timeline (parentTimeline.add(transitionContext.getTimeline(child, ‘out))), the child’s out timeline is (re) setup, but does not first have its out-timeline cleared. This leads to appending the out-timeline to itself over and over again.
|
I created a codesandbox to illustrate the issue I saw: https://codesandbox.io/s/please-help-me-yrt9z7?file=/src/components/multistep-process/MultistepProcess.transitions.ts There, if you look at the console and navigate back and forth between two steps, you can see that tweens repeatedly get added to the Steps' out timelines. This can also be fixed by clearing the timelines manually in their setup functions. |
leroykorterink
force-pushed
the
main
branch
13 times, most recently
from
7830c21
to
d263871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…line
When using the transitionContext to nest a child’s out-timeline in a parent timeline (parentTimeline.add(transitionContext.getTimeline(child, ‘out))), the child’s out timeline is (re) setup, but does not first have its out-timeline cleared. This leads to appending the out-timeline to itself over and over again.