New CONTRIBUTING.md #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor docs are important, let's have some! This is a first pass at it, and feedback (especially in the form of pull requests) is welcome.
| - "documentation" - All things documentation. Developer docs, user docs, | ||
| installation docs, you name it. | ||
| - "duplicate" - Exactly what it says on the tin. | ||
| - "enhancement" - New features, or improvements to existing ones. |
There was a problem hiding this comment.
Enhancement doesn't connote a new feature IMO. Maybe one tag for enhancing existing code, and then a "new feature" one? @ryansb
There was a problem hiding this comment.
We originally had both "feature" and "enhancement" and at the meeting I think we decided we could use one tag for both.
|
@thequbit On one hand, I would think that tags would be used to search for issues as specifically as possible. On the other, keeping things concise is good and there isn't much of a difference between adding a new feature and improving a current one. |
|
Looks great! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor docs are important, let's have some! This is a first pass at
it, and feedback (especially in the form of pull requests) is welcome.
@GabeIsman @thequbit @ismcodes