Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video file as enclosure in RSS feed item #131

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Art4
Copy link
Contributor

@Art4 Art4 commented Apr 7, 2019

Hi,

this PR sets the video url as an attached media object to the RSS feed item. This should fix #75.

Possible enhancements to this PR would be the mime type of the video, but I wasn't sure how to get this data from the elaticsearch result.

            enclosure: {
              url: item.url_video_hd || item.url_video,
              type: '', // mime type?
              size: item.size
            }

Also see the RSS spec as reference: http://www.rssboard.org/rss-specification#ltenclosuregtSubelementOfLtitemgt

Copy link
Member

@bagbag bagbag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bagbag bagbag merged commit e92f258 into mediathekview:master Apr 8, 2019
@bagbag
Copy link
Member

bagbag commented Apr 8, 2019

Thanks!

The rss package MVW uses automatically determines the mime type based on the filename in the url.

@Art4 Art4 deleted the patch-1 branch July 5, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rss Feed for Podcatcher
2 participants