Disable generation of traits by default #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created #12 to reenable traits. |
yawaramin
approved these changes
Aug 14, 2017
| @@ -2,37 +2,28 @@ object HeroFragmentsApi { | |||
| case class HeroAppearancesAndInline(hero: HeroFragmentsApi.HeroAppearancesAndInline.Hero) | |||
| object HeroAppearancesAndInline { | |||
| case class HeroAppearancesAndInlineVariables() | |||
| case class Hero(name: Option[String], appearsIn: Option[List[Option[Episode]]], id: String) extends HeroFragmentsApi.Appearances | |||
| case class Hero(name: Option[String], appearsIn: Option[List[Option[Episode]]], id: String) | |||
There was a problem hiding this comment.
Still seeing a lot of duplicate generated types, any way to reduce this?
More work is needed to correctly generate traits for nested fragments.
jonas
force-pushed
the
disable-trait-gen
branch
from
57ac67b
to
a441bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work is needed to correctly generate traits for nested fragments.