This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Send data to openssl pipe via communicate instead of stdin.write #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a big file that I encrypt using this plugin started breaking Sublime Text: it froze when I entered my password. Looking into it, it was the line
openssl.stdin.write( data.encode("utf-8") )
that was the issue. From the subprocess docs,I think this is what was happening, as it's only big files that break it. I moved the data input to the communicate line, and now it works for me.
I only realised the solution was so simple just now, and before realising that I made a fork of your plugin using the PyCrypto module that went on the package manager today! I'm not sure whether to keep it since it isn't really needed any more.