Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an error message to users when sys.facility_not_found is generated. #6650

Closed
Tracked by #49
benkags opened this issue Sep 22, 2020 · 6 comments
Closed
Tracked by #49

Comments

@benkags
Copy link

benkags commented Sep 22, 2020

Is your feature request related to a problem? Please describe.
When using update_clinic transition and an unregistered phone number submits a report for a 'not public' form i.e "public_form": false, a sys.facility_not_found error is generated marking the report invalid. There does not exist a mechanism for us to notify the reporting user that they are not registered and as a result their report was not successfully accepted.

Describe the solution you'd like
It would useful to have the ability send an SMS to the user if an SMS report they submitted was marked invalid because their phone number is not recognized.

Describe alternatives you've considered
n/a

Additional context

@benkags benkags added the Type: Feature Add something new label Sep 22, 2020
@MaxDiz MaxDiz added this to Needs Triage in End Users Backlog via automation Sep 22, 2020
@n-orlowski n-orlowski moved this from Needs Triage to To do in End Users Backlog Oct 5, 2020
@christinawere
Copy link

christinawere commented Feb 3, 2021

cc @joyannee @njogz @katanu

@michaelkohn michaelkohn added the Status: Blocked waiting for info Blocked waiting for more information label Mar 3, 2021
@michaelkohn michaelkohn added this to Ready for dev in Dev team workstream via automation Mar 3, 2021
@michaelkohn michaelkohn added Status: Blocked waiting for info Blocked waiting for more information and removed Status: Blocked waiting for info Blocked waiting for more information labels Mar 3, 2021
@njogz njogz self-assigned this Mar 18, 2021
@njogz njogz moved this from Ready for dev to Dev in progress in Dev team workstream Mar 22, 2021
@garethbowen garethbowen added this to Scheduled in 3.12.0 via automation Mar 31, 2021
@abbyad abbyad added this to the 3.12 milestone May 7, 2021
@njogz njogz moved this from Dev in progress to Ready for AT in Dev team workstream May 18, 2021
@njogz
Copy link
Contributor

njogz commented May 18, 2021

This is ready for AT on 6650-send-message-when-facility-not-found-error-generated

@ngaruko ngaruko moved this from Ready for AT to AT in progress in Dev team workstream May 23, 2021
@ngaruko ngaruko self-assigned this May 25, 2021
@ngaruko
Copy link
Contributor

ngaruko commented May 26, 2021

LGTM
Tested on local with standard config

  1. Changed "public_form": true, to false for the 'V' form

  2. submitted a V sms form with a non-existent number

  3. on master,
    image

  4. on the branch, a message is send to the number
    image
    and
    image

Note: Not sure if it is a biggie @njogz , but I think the Errors would have kept the existing sys.facility_not_found code and use messages.generic.sys.facility_not_found for the message sent back to the submitter ? Or something rather weird in the UI as the field doesn't even seem to have been translated (while the translation actually exists!)
image

@njogz
Copy link
Contributor

njogz commented May 31, 2021

@ngaruko the translation issue is now fixed.

@ngaruko
Copy link
Contributor

ngaruko commented May 31, 2021

LGTM - Thanks @njogz . Ready to merge
image

@ngaruko ngaruko moved this from AT in progress to Ready to merge in Dev team workstream May 31, 2021
@dianabarsan
Copy link
Member

This has been merged to master.

End Users Backlog automation moved this from To do to Done Jun 1, 2021
Dev team workstream automation moved this from Ready to merge to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Add something new
Projects
No open projects
Development

No branches or pull requests

7 participants