Skip to content

Commit

Permalink
Don't confuse jshint by talking about jshint
Browse files Browse the repository at this point in the history
  • Loading branch information
alxndrsn committed Jun 28, 2018
1 parent 5ca201c commit 2a43669
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v1.17.4
* Don't confuse jshint by talking about jshint
* Fix: first scheduled_task date is incorrect

## v1.17.3
* [compile-app-settings] allow console.log() statements

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "medic-conf",
"version": "1.17.3",
"version": "1.17.4",
"description": "Configure Medic Mobile deployments",
"main": "index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/lib/jshint-with-report.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ const DEFAULT_OPTS = {
module.exports = (description, code, options) => {
options = _.extend(options, DEFAULT_OPTS);

// jshint can't detect repeated declarations in the global scope, so we wrap
// our code in a function. Ref: https://github.com/jshint/jshint/issues/3288
// wrap our code in a function because otherwise jshint can't detect repeated
// declarations. Ref: https://github.com/jshint/jshint/issues/3288
jshint(`(function() {
${code}
}());`, options);
Expand Down

0 comments on commit 2a43669

Please sign in to comment.