Separate attachment-from-file function

src/lib/attachment-from-file.js

@@ -0,0 +1,24 @@
+const fs = require('./sync-fs');
+
+module.exports = path => {
+  const data = fs.readBinary(path);
+  const mime = mimeTypeFor(path);
+  return {
+    content_type: mime,
+    data: new Buffer(data),
+  };
+};
+
+function mimeTypeFor(fileName) {
+  const extensionStart = fileName.indexOf('.');
+  const extension = extensionStart === -1 ?
+      fileName :
+      fileName.substring(extensionStart+1);
+
+  switch(extension) {
+    case 'json': return 'application/json';
+    case 'png' : return 'image/png';
+    case 'xml' : return 'application/xml';
+    default: throw new Error(`Unrecongised file extension: ${extension}`);
+  }
+}

src/lib/attachments-from-dir.js

@@ -1,3 +1,4 @@
+const attachmentFromFile = require('./attachment-from-file');
 const fs = require('./sync-fs');
 const warn = require('./log').warn;
 
@@ -8,26 +9,7 @@ module.exports = dir => {
   fs.readdir(dir)
     .forEach(fileName => {
       const filePath = `${dir}/${fileName}`;
-      const data = fs.readBinary(filePath);
-      const mime = mimeTypeFor(fileName);
-      attachments[fileName] = {
-        content_type: mime,
-        data: new Buffer(data),
-      };
+      attachments[fileName] = attachmentFromFile(filePath);
     });
   return attachments;
 };
-
-function mimeTypeFor(fileName) {
-  const extensionStart = fileName.indexOf('.');
-  const extension = extensionStart === -1 ?
-      fileName :
-      fileName.substring(extensionStart+1);
-
-  switch(extension) {
-    case 'json': return 'application/json';
-    case 'png' : return 'image/png';
-    case 'xml' : return 'application/xml';
-    default: throw new Error(`Unrecongised file extension: ${extension}`);
-  }
-}