Skip to content

Commit

Permalink
Resolve TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
alxndrsn committed Oct 31, 2017
1 parent d669741 commit 549c1f9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/lib/convert-forms.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ const xls2xform = (sourcePath, targetPath) =>
// here we fix the form content in arcane ways. Seeing as we have out own fork
// of pyxform, we should probably be doing this fixing there.
const fixXml = (path, hiddenFields, transformer, enketo) => {
// TODO This is not how you should modify XML
// This is not how you should modify XML, but we have reasonable control over
// the input and so far this works OK. Keep an eye on the tests, and any
// future changes to the output of xls2xform.
let xml = fs.read(path)

// The following copies behaviour from old bash scripts, and will create a
Expand Down

0 comments on commit 549c1f9

Please sign in to comment.