Break release if tests are excluded accidentally

medic · Oct 24, 2018 · a12938c · a12938c
1 parent 8d0e996
commit a12938c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
     "clean": "rm -rf ./build/",
     "generate-changelog": "echo 'Generating changelog...' && ./scripts/changelog > CHANGELOG.md && echo 'Changelog generated.'",
     "jshint": "jshint --verbose src/**/*.js test/*.js test/**/*.js",
-    "release": "npm run --silent generate-changelog && ./scripts/dirty-repo-check && git push && git tag v$(jq -r .version package.json) && git push --tags && npm publish",
+    "release": "./scripts/reject-excluded-tests && npm run --silent generate-changelog && ./scripts/dirty-repo-check && git push && git tag v$(jq -r .version package.json) && git push --tags && npm publish",
     "test": "npm run jshint && npm run clean && mkdir -p build/test && cp -r test/data build/test/data && cd build/test && mocha ../../test/**/*.spec.js"
   },
   "bin": {

diff --git a/scripts/reject-excluded-tests b/scripts/reject-excluded-tests
@@ -0,0 +1,6 @@
+#!/bin/bash -eu
+if grep -Er '\.only\(' test; then
+	echo '!!!'
+	echo '!!! .only() call found in mocha test code'
+	echo '!!!'
+fi
diff --git a/test/lib/filter-properties.spec.js b/test/lib/filter-properties.spec.js
@@ -2,7 +2,7 @@ const assert = require('chai').assert;
 
 const filterProperties = require('../../src/lib/filter-properties');
 
-describe.only('filter-properties', () => {
+describe('filter-properties', () => {
   // GOOD inputs
   [
     {