Don't allow unmasked password entry via --instance

medic · Jan 26, 2018 · a7d0a9f · a7d0a9f
1 parent f6f2cb0
commit a7d0a9f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -52,7 +52,9 @@ To upgrade to the latest version
 
 ### To a specific Medic instance
 
-	medic-conf --instance username:password@instance-name.dev
+	medic-conf --instance instance-name.dev
+
+Username `admin` is used.  A prompt is shown for entering password.
 
 ### To an arbitrary URL
 

diff --git a/bin/medic-conf.js b/bin/medic-conf.js
@@ -33,7 +33,8 @@ switch(args[0]) {
 
 //> instance URL handling:
   case '--instance':
-    instanceUrl = `https://${args[1]}.medicmobile.org`;
+    const password = readline.question('🔑  Password: ', { hideEchoBack:true })
+    instanceUrl = `https://admin:${password}@${args[1]}.medicmobile.org`;
     shift(2);
     break;
   case '--local':

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "medic-conf",
-  "version": "1.10.0",
+  "version": "1.10.1",
   "description": "Configure Medic Mobile deployments",
   "main": "index.js",
   "scripts": {

diff --git a/src/cli/usage.js b/src/cli/usage.js
@@ -25,8 +25,8 @@ ${bold('SPECIFYING URL')}
 	--local
 		Upload to http://admin:pass@localhost:5988
 
-	--instance <username:password@instance-name>
-		Upload to https://username:password@instance-name.medicmobile.org
+	--instance <instance-name>
+		Upload to https://admin:<password>@instance-name.medicmobile.org
 
 	--url <url>
 		Upload to URL specified.