[compile-app-settings] use default jshint settings

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## v1.16.16
+* [compile-app-settings] use default jshint settings
+
 ## v1.16.15
 * [compile-contact-summary] fix test
 * [compile-app-settings] share jshint reporting code

package.json

@@ -1,6 +1,6 @@
 {
   "name": "medic-conf",
-  "version": "1.16.15",
+  "version": "1.16.16",
   "description": "Configure Medic Mobile deployments",
   "main": "index.js",
   "scripts": {

src/lib/compile-contact-summary.js

@@ -5,14 +5,7 @@ const templatedJs = require('../lib/templated-js');
 
 function lint(code) {
   jshintWithReport('contact-summary', code, {
-    esversion: 5,
-    eqeqeq: true,
-    funcscope: true,
-    latedef: 'nofunc',
-    nonbsp: true,
     predef: [ 'contact', 'lineage', 'reports' ],
-    undef: true,
-    unused: true,
   });
 }
 

src/lib/compile-nools-rules.js

@@ -8,14 +8,7 @@ const templatedJs = require('./templated-js');
 
 function lint(code) {
   jshintWithReport('nools rules', code, {
-    esversion: 5,
-    eqeqeq: true,
-    funcscope: true,
-    latedef: 'nofunc',
-    nonbsp: true,
     predef: [ 'c', 'emit', 'Contact', 'Target', 'Task', 'Utils' ],
-    undef: true,
-    unused: true,
   });
 }
 

src/lib/jshint-with-report.js

@@ -1,7 +1,28 @@
+const _ = require('lodash');
 const jshint = require('jshint').JSHINT;
 const withLineNumbers = require('./with-line-numbers');
 
+const DEFAULT_OPTS = {
+  bitwise: true,
+  esversion: 5,
+  eqeqeq: true,
+  freeze: true,
+  funcscope: true,
+  futurehostile: true,
+  latedef: 'nofunc',
+  noarg: true,
+  nocomma: true,
+  nonbsp: true,
+  nonew: true,
+  notypeof: true,
+  shadow: 'inner',
+  undef: true,
+  unused: true,
+};
+
 module.exports = (description, code, options) => {
+  options = _.extend(DEFAULT_OPTS, options);
+
   jshint(code, options);
 
   if(jshint.errors.length) {