Ability to delete a translation key

[abbyad]

As a configurer I want to be able to delete unused translation keys so that they don't bloat the instance.

Once a translation key has been added it is not possible to remove it. This makes it not only difficult to correct mistakes, but also difficult to remove labels that may have been included with the default configuration that are not being used.

We could have an UI for removing individual keys, but there are occasions that we'd want to delete multiple keys at once, which could perhaps be done by re-importing the translations with the unused keys removed.

[mandric]

Wonder if you can set it to null or something that will evaluate to false as a temporary workaround? @abbyad can you give an update here?

[abbyad]

Setting them to null would help reduce bloat, but we should still support removing keys.

[abbyad]

Removed the Triaged label since this issue is not in a Project.

[garethbowen]

@abbyad All issues need some Status label or they will come up for triage again. IMO it doesn't need to be in a project to be triaged.

[garethbowen]

Yeah unfortunately this is an issue with all our settings, hopefully it'll be fixed by medic/cht-conf#113

For now I think just add the button and we'll sort out the rest later.

[garethbowen]

For AT:

• add a translation key, click on edit the translation, click the delete button, make sure it's gone.
• make sure the translation keys we ship cannot be deleted.

[ngaruko]

Would you like to have a second look at this on your local @wtekeu . This is what happened when I tested this. I added a new translation and when I deleted it, there were errors both in the UI and in the console. I clicked delete again and translations were deleted but the key stayed. Then I tried to edit that translation and lo and behold the app crashes - and it is down as I type this. Whether it is related or a rather unfortunate coincidence, I cannot tell! Might be also related to #5062 ... Didn't take any screenshots or error logs as I was expecting to repeat this a couple of times to confirm.
Some errors in logs:

TypeError: Cannot read property 'replace' of null
Dec 13 13:59:39 gamma-dev gamma-dev-medic-api-logs:  (gamma-xxxxxx) | [2018-12-13 06:59:38] 2018-12-13 06:59:38 INFO: Merging translations… 
Dec 13 13:59:39 gamma-dev gamma-dev-medic-api-logs:  (gamma-dev-xxxxx) |     at result.rows.forEach.row (/srv/software/medic-api/md5-G0JZAWK5AjbNNcsCThkzQ==/src/config.js:86:57)

[tookam]

@ngaruko #5062 has been fixed and is ready for AT.

[ngaruko]

LGTM.
Added key can be deleted.
Translation keys we ship cannot be deleted. Just a nitpick, maybe we should grey out or hide the delete button on these un-deletable keys, but let us close that and suggest the idea in a different issue if needed, unless you think it is that important or an easy-win @abbyad?

[garethbowen]

@ngaruko Yes we should definitely disable the delete button if you can't delete it. What happens currently? Just nothing?

@wtekeu Can you have a look at this improvement at some point?

[ngaruko]

Thanks @garethbowen . At the moment, for shipped translations, the edit translation modal disappear onDelete, sort of same behaviour as the Cancel button.
Pushing it back to you @wtekeu ...

[ngaruko]

LGTM...
Closing...