Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get audit log #4802

Closed
IgorProtsenkoOd opened this issue Aug 29, 2018 · 4 comments
Closed

Cannot get audit log #4802

IgorProtsenkoOd opened this issue Aug 29, 2018 · 4 comments
Assignees
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects

Comments

@IgorProtsenkoOd
Copy link
Contributor

Steps to reproduce:

  1. Login as admin
  2. Navigate to /medic/_design/medic-admin/_rewrite/#/export/audit-logs
  3. Click Export button

What should happen:
Audit log is prepared and downloaded

What actually happens:
App hangs on spinner, single request is sent to
GET /api/v1/export/audit?format=xml&locale=en HTTP/1.1

  • Instance: (alpha.dev.medicmobile.org, etc)
  • Browser: Firefox, Chrome. Latest
  • Client platform: Windows
  • Version: 3.2.0

Other:
According to Diana Barsan:
API auth component was refactored to use Promises, while the Export component still expects it to use callbacks.

@IgorProtsenkoOd IgorProtsenkoOd added this to To do in 3.3.0 via automation Aug 29, 2018
@IgorProtsenkoOd IgorProtsenkoOd added the Priority: 3 - Low Can be bumped from the release label Aug 29, 2018
@SCdF
Copy link
Contributor

SCdF commented Aug 29, 2018

As with all of these export issues that get raised, I'm not convinced anyone uses this export and we should drop it instead of fixing it. One less thing to maintain :-)

@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended Status: 1 - Triaged labels Aug 29, 2018
@abbyad
Copy link
Contributor

abbyad commented Aug 30, 2018

I was asked today about export of forms with images... so there may be users that use some of it. Do we have any activity tracking/logging to see which endpoints do get used?

@Jodge Jodge self-assigned this Oct 12, 2018
@dianabarsan dianabarsan moved this from To do to In progress in 3.3.0 Oct 12, 2018
dianabarsan pushed a commit that referenced this issue Oct 16, 2018
Fixes v1 export expecting auth to be callback based instead of promise based. 

#4802
@dianabarsan dianabarsan assigned dianabarsan and unassigned Jodge Oct 16, 2018
@dianabarsan
Copy link
Member

dianabarsan commented Oct 16, 2018

Calling Auth with a callback instead of a promise has been fixed. Unfortunately there is another bug caused by compression - where when using res.write method, calling flush method is required to actually send data.

tookam pushed a commit that referenced this issue Oct 19, 2018
Fixes v1 export expecting auth to be callback based instead of promise based. 

#4802
dianabarsan added a commit that referenced this issue Oct 31, 2018
Because of compression package, it's necessary to call flush after write so data is actually compressed and sent to the client.

#4802
@dianabarsan dianabarsan removed their assignment Oct 31, 2018
@dianabarsan dianabarsan moved this from In progress to Acceptance testing in 3.3.0 Oct 31, 2018
@ngaruko ngaruko self-assigned this Nov 19, 2018
@ngaruko
Copy link
Contributor

ngaruko commented Nov 22, 2018

LGTM.
Tested on gamma.dev v3.3

@ngaruko ngaruko closed this as completed Nov 22, 2018
3.3.0 automation moved this from Acceptance testing to Done Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.3.0
  
Done
Development

No branches or pull requests

7 participants