Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tools & APIs #111

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jan 14, 2024

  • Update tool versions
  • Update APIs

controller_gen, evntest, ginkgo, goImports, op, operator-sdk and envtest k8s
Mostly controller-gen and operator-sdk changes
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content
Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Jan 14, 2024

/test 4.15-openshift-e2e

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Jan 14, 2024

/test 4.15-openshift-e2e

@razo7
Copy link
Member Author

razo7 commented Jan 14, 2024

/test 4.15-openshift-e2e

@clobrano
Copy link
Contributor

Can you add a comment in the last commit about why the webhook update was needed?

@razo7
Copy link
Member Author

razo7 commented Jan 15, 2024

Can you add a comment in the last commit about why the webhook update was needed?

There were some breaking changes in sigs.k8s.io/controller-runtime v0.14.5 -> v0.16.3 (see v0.15.0 and v0.16.0).

Some breaking changes in sigs.k8s.io/controller-runtime v0.14.5 -> v0.16.3
@razo7
Copy link
Member Author

razo7 commented Jan 15, 2024

/test 4.15-openshift-e2e

@clobrano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@razo7 razo7 marked this pull request as ready for review January 15, 2024 13:30
@razo7
Copy link
Member Author

razo7 commented Jan 15, 2024

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Jan 16, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Jan 16, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@razo7: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@razo7
Copy link
Member Author

razo7 commented Jan 16, 2024

oops 😃
I meant to retest
/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 761b790 into medik8s:main Jan 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants