Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing must-gather image from makefile #115

Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jan 30, 2024

Discarding the build and push of NMO must-gather image.

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@razo7 razo7 changed the title Missing Image Registry for must-gather Removing must-gather image from makefile Jan 30, 2024
@razo7 razo7 force-pushed the fix-must-gather-repo-location-2 branch from 9515c50 to a47bd2d Compare January 30, 2024 08:23
NMO must-gather image is irrelevant and Medik8s must-gather replace its logic. Therefore, there is no need to build and push this image anymore
@razo7 razo7 force-pushed the fix-must-gather-repo-location-2 branch from a47bd2d to c90c9b1 Compare January 30, 2024 08:26
@razo7
Copy link
Member Author

razo7 commented Jan 30, 2024

/test 4.15-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review January 30, 2024 12:13
@razo7
Copy link
Member Author

razo7 commented Jan 30, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 9b53a7d into medik8s:main Jan 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants