Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip previous version validation in CI #124

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Mar 13, 2024

Why we need this PR

Should fix an error when VERSION equals CI_VERSION, so it would skip the previous version validation in CI

Error in post-submit automation

make[1]: Entering directory '/home/go/src/github.com/medik8s/node-maintenance-operator'
924
Error: PREVIOUS_VERSION must be set for the selected VERSION
VERSION equals CI_VERSION,

Changes made

Modify the verify-previous-version target so it fails when VERSION doesn't equal CI_VERSION.
Similar to SNR PR

Should fix an error when VERSION equals to CI_VERSION

Signed-off-by: oraz <oraz@redhat.com>
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@razo7
Copy link
Member Author

razo7 commented Mar 13, 2024

The PR is not affecting the code, but rather the GitHub CI so no need to set the PR as draft

@razo7 razo7 marked this pull request as ready for review March 13, 2024 15:02
@openshift-ci openshift-ci bot requested review from beekhof and slintes March 13, 2024 15:02
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 487905b into medik8s:main Mar 13, 2024
14 checks passed
@razo7
Copy link
Member Author

razo7 commented Mar 13, 2024

/cherry-pick release-0.17

@openshift-cherrypick-robot

@razo7: new pull request created: #125

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants