Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extend E2E Test Timeout for Flaky Tests #88

Closed
wants to merge 4 commits into from

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 30, 2023

NMO E2E test have been quite flaky lately, thus I was looking on the last failed PRs of NMO for OCP 4.11, 4.12, 4.13, and 4.14 (from March 16th), in order to see why the E2E tests were flaky.

There are four questionable tests that by extending there test time we might let them finish successfully:

  1. for the 1st master/control-plane node - should succeed
  2. for the 2nd master/control-plane node - should fail
  3. should result in resetted node status
  4. should have invalidated the lease

…hould succeed

This test is sometimes flaky, and possibly waiting a second we will stop get ErrorControlPlaneQuorumViolation error anymore
…hould faile

This test is sometimes flaky, and possibly by waiting double the time the error won't persist
This test is sometimes flaky, and possibly by waiting double the time the error won't persist
This test is sometimes flaky, and possibly by waiting double the time the error won't persist
@openshift-ci openshift-ci bot requested review from mshitrit and slintes April 30, 2023 09:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2023

/retest

@razo7 razo7 changed the title Extend E2E Test Timeout for Flaky Tests [WIP] Extend E2E Test Timeout for Flaky Tests Apr 30, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2023

@razo7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-openshift-e2e 0cab53c link true /test 4.11-openshift-e2e
ci/prow/4.14-openshift-e2e 0cab53c link true /test 4.14-openshift-e2e
ci/prow/4.15-ci-index 0cab53c link true /test 4.15-ci-index
ci/prow/4.15-openshift-e2e 0cab53c link true /test 4.15-openshift-e2e
ci/prow/4.15-images 0cab53c link true /test 4.15-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@razo7
Copy link
Member Author

razo7 commented Dec 31, 2023

e2e tests are not flaky as in the past. we might revisit this PR in the future.

@razo7 razo7 closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants