Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NMO to use latest common version #92

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Update NMO to use latest common version #92

merged 2 commits into from
Jul 3, 2023

Conversation

mshitrit
Copy link
Member

No description provided.

@mshitrit
update to common 1.2.0
336c0a2 
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
@mshitrit
adjust to use shared code from common
93f8eca 
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.11-ci-index
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.12-ci-index
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.13-ci-index
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.14-ci-index
  • /test 4.14-images
  • /test 4.14-openshift-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

/test 4.13-openshift-e2e

@mshitrit mshitrit changed the title [WIP] Update common version Update common version Jun 28, 2023
@mshitrit mshitrit changed the title Update common version Update NMO to use latest common version Jun 28, 2023
@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2023
@mshitrit mshitrit marked this pull request as ready for review July 3, 2023 12:36
@mshitrit
Copy link
Member Author

mshitrit commented Jul 3, 2023

/unhold

@openshift-ci openshift-ci bot requested review from beekhof and clobrano July 3, 2023 12:37
@razo7
Copy link
Member

razo7 commented Jul 3, 2023

/retest

1 similar comment
@mshitrit
Copy link
Member Author

mshitrit commented Jul 3, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit b644104 into medik8s:main Jul 3, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razo7 razo7 razo7 left review comments

@beekhof beekhof Awaiting requested review from beekhof

@clobrano clobrano Awaiting requested review from clobrano

Assignees

@clobrano clobrano

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mshitrit @razo7 @clobrano @openshift-merge-robot