Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): raised ansi regex version due to vulnerability #38

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

jcabot21
Copy link
Contributor

@jcabot21 jcabot21 commented Oct 7, 2021

Vulnerability was being alerted by dependabot. Updated in package json.

@medikoo
Copy link
Owner

medikoo commented Oct 7, 2021

@jcabot21 thanks for raising that. Still we cannot upgrade to ansi-regex@5 as it's incompatible with CJS modules format, and also it drops support for old Node.js versions, which cli-color@2 is obliged to support.

I believe best we can do, is to include ansi-regex functionality internally

@medikoo medikoo self-assigned this Oct 7, 2021
@jcabot21
Copy link
Contributor Author

jcabot21 commented Oct 7, 2021

@medikoo Thanks for the quick feedback. I updated the pull request, bringing in functionality.

Copy link
Owner

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jcabot21 ! Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants