Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability in transitive ansi-regex dependency #5

Closed
trygveaa opened this issue Oct 4, 2021 · 3 comments · Fixed by #6
Closed

Security vulnerability in transitive ansi-regex dependency #5

trygveaa opened this issue Oct 4, 2021 · 3 comments · Fixed by #6

Comments

@trygveaa
Copy link

trygveaa commented Oct 4, 2021

One of the dependencies here is has-ansi: ^4.0.1. This in turn depends on ansi-regex: ^4.1.0 which recently got a security vulnerability: GHSA-93q8-gq69-wqmw

Could you please upgrade has-ansi to 5.0.1 which resolves it?

@medikoo
Copy link
Owner

medikoo commented Oct 4, 2021

@trygveaa Thanks for reporting

The problem with has-ansi@5 is that it drops support for Node.js v10 (and log-node at v8 is still obliged to support it), and more importantly, it's just an ESM module, which from the CJS context can be retrieved only asynchronously.

Nonetheless we probably copy has-ansi logic so it's inline to mitigate that issue

@trygveaa
Copy link
Author

trygveaa commented Oct 4, 2021

Ah, okay. I suppose we could ask for a backport to has-ansi 4.x, they did a backport of ansi-regex to a version before changing to ESM.

@medikoo
Copy link
Owner

medikoo commented Oct 4, 2021

Ah, okay. I suppose we could ask for a backport to has-ansi 4.x,

@trygveaa that feels as great idea. As has-ansi 5x introduces a big shift (different modules format)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants