refactor: Improve variable naming

medikoo · Jul 10, 2020 · faccc70 · faccc70
1 parent 585deb0
commit faccc70
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/private/setup-dependency/install-external/index.js b/lib/private/setup-dependency/install-external/index.js
@@ -34,9 +34,9 @@ module.exports = async dependencyContext => {
 		latestSupportedPublishedVersion,
 		versionRange
 	} = dependencyContext;
-	const wasInstalled = await isDirectory(path);
-	const packageJson = wasInstalled ? getPackageJson(path) : null;
-	if (latestSupportedPublishedVersion && wasInstalled) {
+	const isInstalled = await isDirectory(path);
+	const packageJson = isInstalled ? getPackageJson(path) : null;
+	if (latestSupportedPublishedVersion && isInstalled) {
 		if (optionalChaining(packageJson, "version") === latestSupportedPublishedVersion) {
 			// Seems up to date, but let's follow with quick sanity check and confirm whether
 			// there are corresponding folders for subdependencies
@@ -65,7 +65,7 @@ module.exports = async dependencyContext => {
 		prepareDependency(name, targetVersion, externalContext)
 	);
 	if (!sourceDirname) return;
-	if (wasInstalled && packageJson && packageJson._npmCrossLinkCacheName) {
+	if (isInstalled && packageJson && packageJson._npmCrossLinkCacheName) {
 		const cachePackageJson = getPackageJson(sourceDirname);
 		if (
 			cachePackageJson &&
@@ -78,7 +78,7 @@ module.exports = async dependencyContext => {
 	log.notice("%s installing %s @ %s", dependentContext.name, name, targetVersion);
 
 	dependentContext.installationJobs.add(
-		`${ wasInstalled ? "update" : "install" }-dependency:${ name }`
+		`${ isInstalled ? "update" : "install" }-dependency:${ name }`
 	);
 	await copyDir(sourceDirname, path);