Allow warmupFunction and log detachments #2
Conversation
index.js
Outdated
| @@ -107,9 +116,10 @@ Object.defineProperties( | |||
| return new Ec2({ region: this.serverless.service.provider.region }); | |||
| }), | |||
| functionNames: d(function () { | |||
| const warmupFunction = this.serverless.service.custom.warmup ? [this.serverless.service.custom.warmup.name] : []; | |||
There was a problem hiding this comment.
custom may not be set, and actually CI fails on that.
Additional question do custom.warmup comes from some plugin?
I think for such custom extra lambdas (from whatever plugins) might be good to propose special option, from which we may read extra names (?)
There was a problem hiding this comment.
That's a better idea let us do that instead 👍
|
It's such a weird error mesage on test. |
It's because test doesn't expose some errors as it should. I've fixed it in master, just merge and after I've additionally updated dependencies, and new lint rule prompted me to split |
Adds: