Merge pull request #72 from mediocre/usps-bad-response

Error out if neither TrackResponse or Error are returned (invalid xml or garbage response)
mediocre · Jun 1, 2023 · a91dac0 · a91dac0
2 parents c400f2b + ecabd95
commit a91dac0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/carriers/usps.js b/carriers/usps.js
@@ -95,7 +95,7 @@ function USPS(options) {
                 } else if (data.Error) {
                     // Invalid credentials or Invalid Tracking Number
                     return callback(new Error(data.Error.Description[0]));
-                } else if (data.TrackResponse.TrackInfo[0].Error) {
+                } else if (!data?.TrackResponse?.TrackInfo?.[0] || data.TrackResponse.TrackInfo[0].Error) {
                     // No Tracking Information
                     return callback(null, results);
                 }

diff --git a/package.json b/package.json
@@ -40,5 +40,5 @@
         "type": "git",
         "url": "https://github.com/mediocre/bloodhound.git"
     },
-    "version": "1.11.8"
+    "version": "1.11.9"
 }