Changed USERID to USPS_USERID

mediocre · Jul 1, 2019 · b7af236 · b7af236
1 parent 82fed69
commit b7af236
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/carriers/usps.js b/carriers/usps.js
@@ -21,10 +21,10 @@ function USPS(options) {
 
         const obj = {
             TrackFieldRequest: {
-                '@USERID': options.USERID,
+                '@USERID': options.USPS_USERID,
                 Revision: '1',
                 ClientIp: options.ClientIp || '127.0.0.1',
-                SourceId: options.SourceId || 'Mediocre/bloodhound',
+                SourceId: options.SourceId || '@mediocre/bloodhound (+https://github.com/mediocre/bloodhound)',
                 TrackID: {
                     '@ID': trackingNumber
                 }

diff --git a/index.js b/index.js
@@ -10,8 +10,6 @@ function Bloodhound(options) {
     this.guessCarrier = function(trackingNumber) {
         if (fedEx.isTrackingNumberValid(trackingNumber)) {
             return 'FedEx';
-        }else if (pitneyBowes.isTrackingNumberValid(trackingNumber)) {
-            return 'PitneyBowes';
         }else if (usps.isTrackingNumberValid(trackingNumber)) {
             return 'USPS';
         }else return undefined;

diff --git a/test/carriers/usps.js b/test/carriers/usps.js
@@ -7,17 +7,15 @@ describe.only('USPS', function () {
 
     const bloodhound = new Bloodhound({
         usps: {
-            USERID: process.env.USERID,
-            SourceId: process.env.SourceId
+            USPS_USERID: process.env.USPS_USERID
         }
     });
 
     describe('Invalid USPS Credentials', function () {
         it('should return an error for invalid USERID', function (done) {
             const bloodhound1 = new Bloodhound({
                 usps: {
-                    USERID: 'invalid',
-                    SourceId: process.env.SourceId
+                    USPS_USERID: 'invalid'
                 }
             });
             bloodhound1.track('4204210192612927005269000027623688', 'usps', function (err) {