Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newgistics #7

Merged
merged 8 commits into from Jul 3, 2019
Merged

Newgistics #7

merged 8 commits into from Jul 3, 2019

Conversation

aaronmwhitehead
Copy link
Contributor

No description provided.

freshlogic
freshlogic requested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@freshlogic freshlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like deliveredAt and shippedAt need to bet set in the correct timezone and this code assumes UTC.

@freshlogic freshlogic merged commit b12f7ce into master Jul 3, 2019
@freshlogic freshlogic deleted the newgistics branch July 3, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freshlogic freshlogic freshlogic requested changes

@javamatte javamatte Awaiting requested review from javamatte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronmwhitehead @freshlogic