Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to npm pack and publish via github action #11

Merged
merged 5 commits into from
May 29, 2024

Conversation

Bryan-Lester-Dolby
Copy link
Contributor

@Bryan-Lester-Dolby Bryan-Lester-Dolby commented May 10, 2024

Switches to use npm pack instead of the package run-script. Only diff between the tarballs is that npm pack includes all Licenses and Readmes

image

Sample publishing job: https://github.com/medooze/audio-codecs-node/actions/runs/9025637331/job/24801668454?pr=11

@Bryan-Lester-Dolby Bryan-Lester-Dolby changed the title Switch to npm pack and publish via github action [IOPS-3431] Switch to npm pack and publish via github action May 10, 2024
@Bryan-Lester-Dolby Bryan-Lester-Dolby changed the title [IOPS-3431] Switch to npm pack and publish via github action Switch to npm pack and publish via github action May 10, 2024
Copy link
Contributor

@bcostdolby bcostdolby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@Bryan-Lester-Dolby Bryan-Lester-Dolby merged commit 57c0655 into master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants