Always build synthetic access policy #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
reshmakh
approved these changes
Mar 1, 2024
rahul1
approved these changes
Mar 1, 2024
medplumbot
added a commit
that referenced
this pull request
Mar 1, 2024
Always build synthetic access policy (#4074) Upgrade to Chromatic 11 (#4071) Fix setting query timeout (#4072) Enhance batch logs (#4062) Resource table profile support (#4039) Sample bot to parse ORM messages (#4068) fix(ci): `npm ci` before tests (#4067) refactor(ci): parallelize `eslint` and running tests in CI (#4063) fix(ci): remove attempt to comment on PR (#4056) Add callout about using AuditEvent as Subscription criteria (#4044) Clarify in and ni operators for filter search param (#4050)
Merged
codyebberson
pushed a commit
that referenced
this pull request
Mar 1, 2024
Always build synthetic access policy (#4074) Upgrade to Chromatic 11 (#4071) Fix setting query timeout (#4072) Enhance batch logs (#4062) Resource table profile support (#4039) Sample bot to parse ORM messages (#4068) fix(ci): `npm ci` before tests (#4067) refactor(ci): parallelize `eslint` and running tests in CI (#4063) fix(ci): remove attempt to comment on PR (#4056) Add callout about using AuditEvent as Subscription criteria (#4044) Clarify in and ni operators for filter search param (#4050)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
Always build synthetic access policy (#4074) Upgrade to Chromatic 11 (#4071) Fix setting query timeout (#4072) Enhance batch logs (#4062) Resource table profile support (#4039) Sample bot to parse ORM messages (#4068) fix(ci): `npm ci` before tests (#4067) refactor(ci): parallelize `eslint` and running tests in CI (#4063) fix(ci): remove attempt to comment on PR (#4056) Add callout about using AuditEvent as Subscription criteria (#4044) Clarify in and ni operators for filter search param (#4050)
reshmakh
added
auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep refactoring for future where
AccessPolicyis required for allProjectMembershipCurrently, Medplum has the notion of a "null access policy", which is the source of confusion and abuse. We always recommend that all users have an access policy assigned to prevent that confusion.
This PR is performing some prep refactoring to always build a "synthetic" access policy, so even if an access policy is not explicitly defined, an "effective" access policy is available.
There will be additional future work to fill this out: