feat(bot): add support for Prefer: respond-async on Bot/$execute
#4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
ThatOneBro
force-pushed
the
derrick-bot-execute-prefer-async
branch
from
89345ef
to
94d3701
Compare
codyebberson
approved these changes
Apr 29, 2024
| @@ -76,11 +83,51 @@ export interface BotExecutionResult { | |||
| * Assumes that input content-type is output content-type. | |||
| */ | |||
| export const executeHandler = asyncWrap(async (req: Request, res: Response) => { | |||
| if (req.header('Prefer') === 'respond-async') { | |||
| await sendAsyncResponse(req, res, async () => { | |||
| return new Promise<Parameters>((resolve, reject) => { | |||
There was a problem hiding this comment.
Any reason not to make this async?
There was a problem hiding this comment.
I believe this was the only way to make the outer promise resolve after the execution of the inner callback... could be a way to refactor it to an async function but it's not obvious to me at the moment
There was a problem hiding this comment.
Actually I was wrong there was a pretty clear refactor making executeOperation return what was getting passed through the callback and turning everything async
ThatOneBro
force-pushed
the
derrick-bot-execute-prefer-async
branch
from
0f98f14
to
330d207
Compare
|
medplumbot
added a commit
that referenced
this pull request
Apr 29, 2024
Add projectId to batch metrics (#4454)Removing duplicate content fixes #4390 (#4431) feat(agent): support `Prefer: respond-async` for `Agent/$push` (#4455) Update default project access policy for new systemSetting (#4466) Fixes #4463 - remove version history circuit breaker (#4467) [Provider app] Add patient communications tab (#4465) feat(bot): add support for `Prefer: respond-async` on `Bot/$execute` (#4461) Split minor and major version upgrades (#4475) Dependency upgrades 2024-04-29 (#4472) Add Extension to Bot resource (#4474) Fix tar.x import (#4477)
Merged
codyebberson
pushed a commit
that referenced
this pull request
Apr 30, 2024
Add projectId to batch metrics (#4454)Removing duplicate content fixes #4390 (#4431) feat(agent): support `Prefer: respond-async` for `Agent/$push` (#4455) Update default project access policy for new systemSetting (#4466) Fixes #4463 - remove version history circuit breaker (#4467) [Provider app] Add patient communications tab (#4465) feat(bot): add support for `Prefer: respond-async` on `Bot/$execute` (#4461) Split minor and major version upgrades (#4475) Dependency upgrades 2024-04-29 (#4472) Add Extension to Bot resource (#4474) Fix tar.x import (#4477)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Add projectId to batch metrics (#4454)Removing duplicate content fixes #4390 (#4431) feat(agent): support `Prefer: respond-async` for `Agent/$push` (#4455) Update default project access policy for new systemSetting (#4466) Fixes #4463 - remove version history circuit breaker (#4467) [Provider app] Add patient communications tab (#4465) feat(bot): add support for `Prefer: respond-async` on `Bot/$execute` (#4461) Split minor and major version upgrades (#4475) Dependency upgrades 2024-04-29 (#4472) Add Extension to Bot resource (#4474) Fix tar.x import (#4477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4455
Closes #4458