Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(upgrade): add 2 separate PRs so we can choose between them #4517

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/upgrade.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,16 @@ npx npm-check-updates --workspaces --root --upgrade --reject "$EXCLUDE" --target
# Commit and push before running NPM install
git add -u .
git commit -m "Dependency upgrades - step 1"
git push origin "$BRANCH_NAME"
gh pr create --title "Dependency upgrades $DATE" --body "Dependency upgrades" --draft
git push origin "$BRANCH_NAME":"$BRANCH_NAME-no-major-bumps"
gh pr create --title "Dependency upgrades $DATE - no major bumps" --body "Dependency upgrades" --draft

# Reinstall all dependencies
./scripts/reinstall.sh --update

# Commit and push after running NPM install
git add -u .
git commit -m "Dependency upgrades - step 2"
git push origin "$BRANCH_NAME"
git push origin "$BRANCH_NAME":"$BRANCH_NAME-no-major-bumps"
gh pr ready

# Next, optimistically upgrade to the latest versions
Expand All @@ -51,6 +51,7 @@ npx npm-check-updates --workspaces --root --upgrade --reject "$EXCLUDE" --target
git add -u .
git commit -m "Dependency upgrades - step 3"
git push origin "$BRANCH_NAME"
gh pr create --title "Dependency upgrades $DATE - latest" --body "Dependency upgrades" --draft

# Reinstall all dependencies
./scripts/reinstall.sh --update
Expand All @@ -59,3 +60,4 @@ git push origin "$BRANCH_NAME"
git add -u .
git commit -m "Dependency upgrades - step 4"
git push origin "$BRANCH_NAME"
gh pr ready