`PatientSummary` Problem List uses US Core profile #4535

mattlong · 2024-05-09T21:02:33Z

A notable underlying change to facilitate this:

In order to get discriminators with a path of $this working, SliceDefinition now extends InternalSchemaElement. Previously they already had an awful lot of overlap, so this feels like a low risk change to make. The redundancy of SliceDefinition.definition and InternalSchemaElement.description is unfortunate. We could get rid of SliceDefinition.definition and normalize on description, but that would of course be a breaking change which would probably be best to leave for the next major release. If/when this PR gets merged, I'll make an issue to track that.

vercel · 2024-05-09T21:02:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medplum-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 5:28pm
medplum-provider	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 5:28pm
medplum-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 5:28pm
medplum-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 5:28pm

packages/core/src/typeschema/validation.ts

mattlong · 2024-05-09T22:28:30Z

packages/core/src/typeschema/validation.ts

@@ -589,7 +594,17 @@ export function matchDiscriminant(
      if (!value || !sliceElement) {
        return false;
      }
-      if (matchesSpecifiedValue(value, sliceElement)) {
+      if (sliceElement.pattern) {


This is a subtle but potentially validation-breaking change for malformed slice definitions. Since matchesSpecifiedValue returns true by default, checks on elements containing neither .fixed nor .pattern now return false whereas they used to return true. The only time fixed and pattern shouldn't be defined is when we're dealing with slicing by ValueSet which is handled below and retains the permissiveness for now.

@mattwiller - can you comment on this? Seems ok to me, but this is kinda out of my comfort zone.

Yep, Matt and I discussed this and I think this change should be fine. In general, the possibility of malformed profile StructureDefinition resources makes validation tricky unless we assume the underlying profile is valid. Eventually, we may want to add explicit validation checks on the profile before using it for validation of another resource: at least then we could abort and display the issue with the profile

codyebberson

lgtm. I think we should wait for @mattwiller to clarify the matchesSpecifiedValue() change

codyebberson · 2024-05-10T21:23:11Z

packages/core/src/typeschema/types.ts

-export interface SliceDefinition {
+export interface SliceDefinition extends InternalSchemaElement {
+  // narrowed InternalSchemaElement fields
+  slicing?: never;


Would this be more accurate?

export interface SliceDefinition extends Omit<InternalSchemaElement, 'slicing'> {

codyebberson · 2024-05-10T21:26:17Z

packages/core/src/typeschema/validation.ts

@@ -580,7 +580,12 @@ export function matchDiscriminant(
    return false;
  }

-  const sliceElement: InternalSchemaElement = (elements ?? slice.elements)[discriminator.path];
+  let sliceElement: InternalSchemaElement | undefined;
+  if (discriminator.path === '$this') {


Clarifying question: My understanding is that discriminator.path can be a full FHIRPath expression, so we're currently adding support for the special case of === '$this', but still have open future work here?

Yes, that's correct; the Restricted Subset ("Simple"):

All statements SHALL start with the name of the context element (e.g. on a Patient resource, Patient.contact.name.), or SHALL be simply "$this" to refer to the element that has focus

Operators SHALL NOT be used

Only the following functions may be used:

.resolve()

.extension("url")

.ofType(type)

All other functions SHALL NOT be used

codyebberson · 2024-05-10T21:27:13Z

packages/core/src/typeschema/validation.ts

@@ -589,7 +594,17 @@ export function matchDiscriminant(
      if (!value || !sliceElement) {
        return false;
      }
-      if (matchesSpecifiedValue(value, sliceElement)) {
+      if (sliceElement.pattern) {


@mattwiller - can you comment on this? Seems ok to me, but this is kinda out of my comfort zone.

sonarcloud · 2024-05-13T17:24:20Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Fix age display in PatientSummary (#4484)Fixes #4471 - DetectedIssue.status valueset and search param (#4483) Qualify columns with table name in generated SQL (#4487) fix(migrations): only take lock if migrating (#4490) Document updating profiles (#4402) Run expand tests against old and new (#4503) Adding OpenCareHub support post (#4504) [Medplum Provider app] Various fixes and touchups (#4500) ci(agent): add workflow for building agent outside of a release (#4512) feat(agent): `Agent/$reload-config` operation (#4457) Remove broken links to Foo Provider (#4518) Dependency upgrades 2024-05-06 (#4515) PatientSummary and provider app tweaks (#4521) Fixes #4509 - Improve exact match search support for token parameters in `matchesTokenFilter` (#4516) Link to new Demo Applications (#4514) Clarify that autobatching only applies to `GET` requests (#4479) Added missing useEffect dependency in chat demo (#4527) fix: allows CORS for `keyvalue` API (#4476) Fixes #4508 - MeasureReport-subject search param backport (#4530) Fix CLI update-server version flag (#4534) Patient summary appointments and encounters links (#4524) Remove unused DB columns (#4532) fix(agent): unwrap response for `$reload-config` by id (#4542) `PatientSummary` Problem List uses US Core profile (#4535) fix(cli): always exit with exit code 1 after error occurs during command (#4536) Add failing test about validating nested extensions (#4548) Add error message when `cli` fails on login (#4507) Remove functions moved to core (#4547) fix: AttachmentDisplay use uncached url for download link (#4501) feat(agent): respect `Agent.status` and `Agent.channel.endpoint.status` being `off` (#4523) CMS 1500 and Superbill (#4543) Demo Bot: Agent Setup (#4555) feat(Subscription): add `author` as a `SearchParameter` (#4540) Dependency upgrades 2024-05-13 (#4544) Full linked Project ordering in CodeSystem lookup (#4522) Disable super admin refresh tokens (#4492) Minor fixes for the agent setup bot (#4560) docs(agent): document how logging works with `Bot` and `Agent` (#4563) Split rate limits into two buckets (#4568) Properly detect array elements (#4569) Apply filter to ValueSet with expansion.contains (#4570) More efficiently validate included concepts (#4573) Dependency upgrades 2024-05-20 (#4574) tweak(agent): add timezone in status `lastUpdated` time (#4564) fix(client/keyvalue): set keyvalue content-type text (#4575) Allow configuring server default rate limits (#4491) feat(cli): add `token` command to get access token (#4579) Updating device resources and videos (#4578) fix(subscriptions): don't retry ws subs if sub is deleted (#4577) Add support for 'pr' filter operation (#4584) Super admin endpoint for database stats (#4443)

mattlong requested a review from a team as a code owner May 9, 2024 21:02

vercel bot deployed to Preview – medplum-app May 9, 2024 21:04 View deployment

vercel bot deployed to Preview – medplum-provider May 9, 2024 21:10 View deployment

vercel bot deployed to Preview – medplum-www May 9, 2024 21:19 View deployment

vercel bot deployed to Preview – medplum-storybook May 9, 2024 21:25 View deployment

mattlong commented May 9, 2024

View reviewed changes

packages/core/src/typeschema/validation.ts Outdated Show resolved Hide resolved

mattlong commented May 9, 2024

View reviewed changes

packages/core/src/typeschema/validation.ts Outdated Show resolved Hide resolved

mattlong commented May 9, 2024

View reviewed changes

vercel bot deployed to Preview – medplum-storybook May 9, 2024 22:30 View deployment

vercel bot deployed to Preview – medplum-provider May 9, 2024 22:34 View deployment

vercel bot deployed to Preview – medplum-www May 9, 2024 22:41 View deployment

vercel bot deployed to Preview – medplum-app May 9, 2024 22:46 View deployment

vercel bot had a problem deploying to Preview – medplum-app May 9, 2024 23:39 Failure

vercel bot had a problem deploying to Preview – medplum-provider May 9, 2024 23:39 Failure

vercel bot had a problem deploying to Preview – medplum-storybook May 9, 2024 23:43 Failure

mattlong force-pushed the medplum-provider-update-valuesets branch from 45af05e to a20514f Compare May 9, 2024 23:44

vercel bot deployed to Preview – medplum-app May 9, 2024 23:52 View deployment

vercel bot deployed to Preview – medplum-www May 9, 2024 23:59 View deployment

vercel bot deployed to Preview – medplum-provider May 10, 2024 00:03 View deployment

vercel bot deployed to Preview – medplum-storybook May 10, 2024 00:08 View deployment

vercel bot deployed to Preview – medplum-storybook May 10, 2024 00:36 View deployment

vercel bot deployed to Preview – medplum-provider May 10, 2024 00:40 View deployment

vercel bot deployed to Preview – medplum-app May 10, 2024 00:44 View deployment

mattlong self-assigned this May 10, 2024

mattlong added this to the May 31st, 2024 milestone May 10, 2024

vercel bot deployed to Preview – medplum-provider May 10, 2024 19:21 View deployment

vercel bot deployed to Preview – medplum-storybook May 10, 2024 19:27 View deployment

vercel bot deployed to Preview – medplum-app May 10, 2024 19:32 View deployment

codyebberson reviewed May 10, 2024

View reviewed changes

reshmakh added the react Features, fixes and enhancements to react component library label May 10, 2024

mattlong and others added 13 commits May 13, 2024 09:56

Use correct valueset urls

f8728ab

Use US Core profile in ConditionDialog

fe5123d

Fix bug when clicking edit and then Add

30a1c4c

SliceDefinition extends InternalSchemaElement

291256e

Add tests for $this discriminator path

5993bb4

Fix tests

3dcf06b

Clean up commented out code

ce2e59e

Sonar appeasement

51206d3

PatientSummary medications uses US Core profile

2b9366b

Move profile utils to core

c33e6d3

AllergyIntolerance uses US Core profile

9a47e30

Use consistent pattern to apply profiles

3c95516

PR feedback

99579fb

mattlong force-pushed the medplum-provider-update-valuesets branch from cb9418a to 99579fb Compare May 13, 2024 17:04

codyebberson approved these changes May 13, 2024

View reviewed changes

mattlong enabled auto-merge May 13, 2024 17:06

vercel bot deployed to Preview – medplum-app May 13, 2024 17:09 View deployment

vercel bot deployed to Preview – medplum-www May 13, 2024 17:17 View deployment

vercel bot deployed to Preview – medplum-storybook May 13, 2024 17:23 View deployment

mattlong added this pull request to the merge queue May 13, 2024

vercel bot deployed to Preview – medplum-provider May 13, 2024 17:28 View deployment

Merged via the queue into main with commit 2932e2e May 13, 2024
32 checks passed

mattlong deleted the medplum-provider-update-valuesets branch May 13, 2024 17:48

mattlong mentioned this pull request May 13, 2024

Actually remove functions that were moved to core #4547

Merged

medplumbot mentioned this pull request May 25, 2024

Release Version 3.1.6 #4589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`PatientSummary` Problem List uses US Core profile #4535

`PatientSummary` Problem List uses US Core profile #4535

mattlong commented May 9, 2024 •

edited

Loading

vercel bot commented May 9, 2024 •

edited

Loading

mattlong May 9, 2024 •

edited

Loading

codyebberson May 10, 2024

mattwiller May 10, 2024

codyebberson left a comment

codyebberson May 10, 2024

codyebberson May 10, 2024

mattlong May 13, 2024

codyebberson May 10, 2024

sonarcloud bot commented May 13, 2024

PatientSummary Problem List uses US Core profile #4535

PatientSummary Problem List uses US Core profile #4535

Conversation

mattlong commented May 9, 2024 • edited Loading

vercel bot commented May 9, 2024 • edited Loading

mattlong May 9, 2024 • edited Loading

Choose a reason for hiding this comment

codyebberson May 10, 2024

Choose a reason for hiding this comment

mattwiller May 10, 2024

Choose a reason for hiding this comment

codyebberson left a comment

Choose a reason for hiding this comment

codyebberson May 10, 2024

Choose a reason for hiding this comment

codyebberson May 10, 2024

Choose a reason for hiding this comment

mattlong May 13, 2024

Choose a reason for hiding this comment

codyebberson May 10, 2024

Choose a reason for hiding this comment

sonarcloud bot commented May 13, 2024

Quality Gate passed

`PatientSummary` Problem List uses US Core profile #4535

`PatientSummary` Problem List uses US Core profile #4535

mattlong commented May 9, 2024 •

edited

Loading

vercel bot commented May 9, 2024 •

edited

Loading

mattlong May 9, 2024 •

edited

Loading