(updates) Change the counter for the params loop #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The params loop use the total of found items. But we need the count of elements in the array, which can be different from the total because of pagination. The total can be 55, and the count from the array = 10 (because we display 10 elements per page).
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request addresses the need to accurately reflect the count of elements displayed per page in a paginated list, rather than using the total number of found items. This change is crucial for scenarios where the total number of items and the number of items displayed per page differ due to pagination.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the logic for calculating the count of elements per page is thoroughly tested, especially in edge cases where the number of items might be less than the per-page limit.
- Consider adding documentation or comments in the code to explain why the count of elements in the array is used instead of the total found items, as this could be beneficial for future maintenance.
- Review the implementation to ensure that it seamlessly integrates with existing pagination logic and does not introduce any regressions or unexpected behavior.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The params loop use the total of found items. But we need the count of elements in the array, which can be different from the total because of pagination.
The total can be 55, and the count from the array = 10 (because we display 10 elements per page).