Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javax.servlet-api jar was scoped to compile, and because of this I couldn't run Cantaloupe in Eclipse. When trying to run with
mvn clean tomcat:run
I got:Marking it as provided, everything works in Eclipse. Running
mvn clean package -DskipTests
, I get the.war
and.zip
files.Comparing the WAR and ZIP files, with the contents of Cantaloupe-3.3.2.zip that I just downloaded, everything looks fine. I cannot find the servlet JAR in there. And in the root of the WAR I can see the javax folder. Same for the WAR file within the ZIP.
Am I missing anything? Is that an OK change? If so, it would be easier for users running
mvn tomcat:run
(or jetty, winstone, etc) to develop new features and test :-)Thanks
Bruno