Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return fulfilment options are not filtered in return shipping option modal #6946

Open
gempain opened this issue Apr 4, 2024 · 0 comments
Open

Comments

@gempain
Copy link
Contributor

gempain commented Apr 4, 2024

Bug report

Describe the bug

Say a fulfilment provider returns shipping options:

async getFulfillmentOptions(): Promise<ShippingMethodData[]> {
    // ...
    return [
      ...shippingOptionsData.shipping_methods,
      ...returnShippingOptionsData.shipping_methods.map(method => ({
        ...method,
        is_return: true,
      })),
    ];
  }

In the return shipping, I still get all fulfilment providers in the dropdown:

image

I traced the issue here where you're not passing true as second argument.

System information

Medusa version (including plugins): latest
Node.js version:
Database:
Operating system:
Browser (if relevant):

Steps to reproduce the behavior

Expected behavior

Returned fulfilment options from the fulfilment provider should be filtered correctly based on is_return.

Screenshots

Code snippets

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant